Normalize FileserverUpdate process title casing - #70111
Open
dwoz wants to merge 2 commits into
Open
Conversation
The FileserverUpdate class in salt/master.py was registered with the ProcessManager under the name ``FileServerUpdate`` (capital S) via an explicit ``name=`` kwarg, while the class name itself uses a lowercase ``s``. Because ProcessManager falls back to the class name when respawning a process, the initial fork got the process title ``FileServerUpdate`` and any respawn got ``FileserverUpdate``, so a single logical process ended up with two different titles depending on its lifecycle. The log message emitted when applying the fileserver niceness used the capital-S form as well. Normalize every occurrence to ``FileserverUpdate`` to match the class name so process listings, grep/pgrep based monitoring, and log-to-process correlation are consistent across the process lifetime.
Rename the placeholder changelog snippet to use PR saltstack#70111.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileserverUpdatewas registered with the ProcessManager under the nameFileServerUpdate(capital S) via an explicitname=kwarg, while the class name uses lowercases. When the process is respawned, ProcessManager falls back to the class name, so the initial fork gets the titleFileServerUpdateand any respawn getsFileserverUpdate— the same logical process ends up with two different titles across its lifetime.Impact: breaks grep/pgrep based monitoring, log-to-process correlation, and is confusing to operators. This fix normalizes every occurrence (class registration, log message, and log-assertion test) to the canonical class-name casing
FileserverUpdate.Test plan
tests/pytests/integration/_logging/test_multiple_processes_logging.pystill matches on the normalized name.pson a running master showsFileserverUpdateboth before and after a respawn.