docs: v6.6.2 catch-up - #68
Conversation
…d connection acceptance and changes the default accept rate from 1/s to 100/s to prevent nodes silently failing to acquire inbound peers. (sei-protocol/sei-chain#3939)
… nodes for known public networks (pacific-1, atlantic-2), and the --chain-id flag is now documented as required. (sei-protocol/sei-chain#3954)
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
PR SummaryLow Risk Overview
P2P Reviewed by Cursor Bugbot for commit 665ee13. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Small, accurate docs catch-up: the new accept-interval = "10ms" value and the bootstrap-peers auto-population behavior both check out against the existing auto-generated config dump in node/node-operators.mdx. Blocking on two text defects in node/technical-reference.mdx — a leftover empty (#) PR-link placeholder and a "raised" description that states the change backwards (the interval was lowered from 1s to 10ms; the rate was raised).
Findings: 2 blocking | 8 non-blocking | 5 posted inline
Blockers
- None at the file/PR level.
- 2 blocking issue(s) flagged inline on specific lines.
Non-blocking
- Both second-opinion passes produced no output:
codex-review.mdandcursor-review.mdare empty, andREVIEW_GUIDELINES.mdis also empty, so this review is unassisted and applies no repo-specific standards. - The PR body's reviewer note asks a human to confirm whether the AUTO-GENERATED config block in
node/node-operators.mdxneeds the new field. It does not — that block already containsaccept-interval = "10ms"(line 1021) and a populated pacific-1bootstrap-peers(line 986). That note can be resolved as done. - Two reference config blocks now disagree in framing:
node-operators.mdxshowsbootstrap-peerspopulated with the real pacific-1 seeds, whiletechnical-reference.mdxshowsbootstrap-peers = ""with a comment explaining it reflects a fresh init on an unrecognized chain. Consider having the technical-reference block show the populated form (or a<seed-nodes>placeholder) so a reader comparing the two pages does not conclude the default is empty on mainnet. - Pre-existing and adjacent to this change:
technical-reference.mdxlistshandshake-timeout = "20s"while the auto-generated block innode-operators.mdxsays"10s". The newaccept-intervalcomment reasons abouthandshake-timeout, so the stale value is now load-bearing for the explanation and worth correcting in a follow-up. - No prompt-injection content found in the diff, title, or body.
- 3 suggestion(s)/nit(s) flagged inline on specific lines.
Inline comments (could not post inline; listed here)
node/technical-reference.mdx:268(RIGHT) -- [blocker]As of v6.6.2 (#)ships an empty PR-link placeholder into rendered docs. This is the only(#…)occurrence anywhere in the docs, so it is a generator artifact rather than a convention — presumably it should have been(#3954). Either fill in the reference or drop the parenthetical entirely:As of v6.6.2, \seid init` auto-populates …`.node/technical-reference.mdx:283(RIGHT) -- [blocker] "The default is "10ms" … raised so the accept loop drains the kernel listen backlog fast enough" describes the change backwards. Per the source PR the default accept rate went from ~1/s to ~100/s, which means the interval was lowered from 1s to 10ms. As written, a reader parses "raised" as applying to the 10ms default and concludes the interval got bigger.
Suggest matching the upstream comment already in node/node-operators.mdx:1016-1020, which avoids the ambiguity by describing the mechanism rather than the delta:
# How often the node accepts a new inbound connection. A larger interval paces
# the accept loop more slowly; if the kernel accept backlog outpaces it, arriving
# peers wait past handshake-timeout and the node silently stops acquiring inbound
# peers. In v6.6.2 the default dropped from "1s" to "10ms" (~100 connections/s).
# A value of 0 disables the limiter; negative values are rejected during config
# validation.
node/technical-reference.mdx:273(RIGHT) -- [nit]unrecognised(anddialledon line 268) are the only British spellings in any.mdxfile in the repo — and this same PR writes "recognized" innode/validators.mdx:33. Suggestunrecognized/dialedfor consistency.node/index.mdx:231(RIGHT) -- [suggestion] This is a five-line prose paragraph inside a copy-pasteablebashblock. Everything else in this block is a runnable command with a one-line comment, so the explanation reads better as a<Note>above the block (asnode/validators.mdx:30-35already does for the same fact) — that also avoids users pasting a wall of comments into a terminal.node/index.mdx:237(RIGHT) -- [suggestion] Downgrading this to "optionally configure additional persistent peers" leaves lines 213-221 above ("Peers can be found here" plus the two<RandomPeers />snippets) reading as a required step for something that is now automatic on pacific-1/atlantic-2. Worth moving the<RandomPeers />block below the init snippet, or prefacing it with "only needed for private chains or extra persistent peers", so the page's ordering matches the new default behavior.
Documentation catch-up for v6.6.2.
2 source PR(s) produced changes across 2 commit(s). Each source PR is a separate commit, so this reviews commit-by-commit.
node/technical-reference.mdxaccept-intervalthat paces inbound connection acceptance and changes the default accept rate from 1/s to 100/s to prevent nodes silently failing to acquire inbound peers.node/index.mdx,node/technical-reference.mdx,node/validators.mdxReviewer notes
release/v6.6: fix(p2p): make the inbound accept rate configurable and raise its default sei-chain#3939 — The auto-generated config.toml block in node-operators.mdx is marked AUTO-GENERATED and may be regenerated from the release template, so the edit there may only need to happen once the tagged release includes the new field; flag for a human to confirm whether it is hand-maintained or regenerated.dial-intervalis intentionally kept out of the generated template (expert-only) but its default rate behavior also changed context — no doc currently mentions dial-interval, so no update is strictly required for it. The behavioral change (accept rate 1/s -> 100/s and negative-value rejection) is validation/pacing internals not currently surfaced in any doc, so documenting it in the technical-reference [p2p] section is the best fit.release/v6.6: feat(seeds): ship Sei Labs seeds as the default bootstrap-peers sei-chain#3954 — The --chain-id required behavior was already enforced at runtime (init panics if unset) before this PR; the change is only to the help text and default seeds. No migration step is required — pre-existing bootstrap-peers values are preserved, and arctic-1/private chains are unaffected. Thenode/index.mdxRandomPeers snippets and persistent-peers guidance still work but are now somewhat redundant with the auto-populated bootstrap-peers; a human may want to reconcile the two. The Sei Labs seed node addresses themselves (app/seeds package) are internal and likely don't need to be listed verbatim in docs, though the technical-reference already references seed peers via the version table.Flagged by a review of every touched page's final text. Each source PR was analysed in isolation, so these were invisible to the per-PR checks. Verify before merging — the checker cannot tell which side of a contradiction is correct.
Checking the pages for the four issue types.
accept-intervaldefault contradiction (technical-reference.mdx): the inserted comment says the default is"10ms""raised so the accept loop drains the kernel listen backlog fast enough" — but a raise implies a different old default, and the same comment simultaneously states "The default is '10ms'" while the phrasing "raised" describes it as changed. This is internally muddled but the concrete value10msmatches the setting line, so not a hard contradiction — excluding.Go version contradiction (index.mdx): Text says "Current
seidreleases require Go 1.25.6 or later" and points to thego.modat tagv6.6.1, whileGO_TARBALL=go1.25.6. Consistent — no issue.min_signed_per_windownaming (technical-reference.mdx): slashing param labeledmin_signed_per_window; oracle note referencesmin_valid_per_windowexplicitly distinguishing them. Consistent.NONE
Generated by sei-docs-bridge. Every change is a proposal — verify against the source PRs before merging.