feat(valkey): onboard valkey - #1530
Open
SerseusWasTaken wants to merge 2 commits into
Open
Conversation
Relates to STACKITCLI-428
SerseusWasTaken
force-pushed
the
feat/onboard-valkey
branch
from
August 12, 2026 05:37
51be0ae to
6e2dafe
Compare
SerseusWasTaken
marked this pull request as ready for review
August 12, 2026 05:42
Fyusel
reviewed
Aug 12, 2026
|
|
||
| func outputResult(p *print.Printer, model *inputModel, projectLabel, instanceId string, resp *valkey.CreateInstanceResponse) error { | ||
| return p.OutputResult(model.OutputFormat, resp, func() error { | ||
| if model == nil { |
Contributor
There was a problem hiding this comment.
This check should be made before calling this function otherwise model.OutputFormat would crash if model is nil
Contributor
Author
There was a problem hiding this comment.
Where would it crash? I don't think model is accessed between passing and this check
Contributor
There was a problem hiding this comment.
If model is nil, then the call to this function would crash by passing model.OutputFormat
Merging this branch changes the coverage (1 decrease, 11 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Contributor
Author
|
Currently not testable due to API-issue. We will have to wait for a fix |
7 tasks
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to STACKITCLI-428
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)