feat(albwaf): onboard albwaf config - #1563
Open
SerseusWasTaken wants to merge 2 commits into
Open
Conversation
Relates to STACKITCLI-444
SerseusWasTaken
force-pushed
the
feat/onboard-albwaf-configuration
branch
from
August 24, 2026 13:25
a7c378e to
cc4fc26
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
SerseusWasTaken
marked this pull request as ready for review
August 24, 2026 13:53
|
|
||
| func formatLabels(labels map[string]string) string { | ||
| pairs := make([]string, 0, len(labels)) | ||
| for v, k := range labels { |
Contributor
There was a problem hiding this comment.
Suggested change
| for v, k := range labels { | |
| for k, v := range labels { |
| } | ||
|
|
||
| params.Printer.Info("Custom rule group %q deleted.\n", model.Name) | ||
| params.Printer.Outputf("Custom rule group %q deleted.\n", model.Name) |
Contributor
There was a problem hiding this comment.
prints to stdout, breaking -o json
| return fmt.Errorf("delete ALB WAF configuration: %w", err) | ||
| } | ||
|
|
||
| params.Printer.Outputf("WAF configuration %q deleted.\n", model.Name) |
Contributor
There was a problem hiding this comment.
prints to stdout, breaking -o json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Onboards the albwaf config
Update is missing since we only have a PUT endpoint
Relates to STACKITCLI-444
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)