Skip to content

feat(stovepipe): tag controller metrics by queue - #630

Draft
mnoah1 wants to merge 1 commit into
mainfrom
mnoah1/stovepipe-queue-metric-scopes
Draft

feat(stovepipe): tag controller metrics by queue#630
mnoah1 wants to merge 1 commit into
mainfrom
mnoah1/stovepipe-queue-metric-scopes

Conversation

@mnoah1

@mnoah1 mnoah1 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Intent:

  • Make controller metrics attributable to their logical queue.
  • Enforce request-local metric scoping without mutating shared controllers.

Changes:

  • Add a metrics factory that resolves queue-bound scopes from explicit config.
  • Pass typed queue-scoped metrics through every primary and DLQ controller path.
  • Keep pre-decode failures explicitly unscoped and cover queue tags in tests.

Test Plan

  • Exercise primary and DLQ controller metric paths and assert emitted series carry the expected queue tag.
  • Run the affected packages with the Go race detector and targeted Bazel tests.

Revert Plan

  • Revert this commit to restore the prior unscoped controller metrics.

Generated by the 🪄 pr-create skill in devexp-agent-marketplace

Issues

@mnoah1 mnoah1 changed the title feat(stovepipe): tag controller metrics by queue [draft/wip] feat(stovepipe): tag controller metrics by queue Aug 24, 2026
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-queue-metric-scopes branch 2 times, most recently from f27b81b to ab4c26c Compare August 24, 2026 19:22
@mnoah1 mnoah1 changed the title [draft/wip] feat(stovepipe): tag controller metrics by queue feat(stovepipe): tag controller metrics by queue Aug 24, 2026
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-queue-metric-scopes branch 2 times, most recently from ef97e0a to 4b2f50f Compare August 24, 2026 19:38
Summary:
Intent:
- Make controller metrics attributable to their logical queue.
- Enforce request-local metric scoping without mutating shared controllers.

Changes:
- Add a metrics factory that resolves queue-bound scopes from explicit config.
- Pass typed queue-scoped metrics through every primary and DLQ controller path.
- Keep pre-decode failures explicitly unscoped and cover queue tags in tests.

Test Plan:
- Exercise primary and DLQ controller metric paths and assert emitted series carry the expected queue tag.
- Run the affected packages with the Go race detector and targeted Bazel tests.

Revert Plan:
- Revert this commit to restore the prior unscoped controller metrics.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-queue-metric-scopes branch from 4b2f50f to 0a71da9 Compare August 24, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant