refactor: to have similar structure to uutils/coreutils - #262
Open
toggysmith wants to merge 3 commits into
Open
Conversation
toggysmith
force-pushed
the
split-into-separate-crates
branch
from
July 11, 2026 22:24
f811086 to
062bcca
Compare
toggysmith
marked this pull request as draft
July 11, 2026 22:28
toggysmith
marked this pull request as ready for review
July 11, 2026 22:34
sylvestre
force-pushed
the
split-into-separate-crates
branch
from
August 24, 2026 19:09
517a649 to
17daa24
Compare
Collaborator
|
uucore is used by coreutils. i will just rename it to diffutils_core |
Collaborator
|
great work btw :) |
|
GNU diffutils testsuite comparison: |
Contributor
Merging this PR will degrade performance by 3.57%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | cmp_parser |
12.4 µs | 12.8 µs | -3.57% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing toggysmith:split-into-separate-crates (bc9defb) with main (cbc5298)
sylvestre
added a commit
that referenced
this pull request
Aug 24, 2026
GnuTests on #262 reported "PASSED: -8 / FAILED: +12" although the branch changes nothing for the testsuite.
sylvestre
added a commit
that referenced
this pull request
Aug 24, 2026
GnuTests on #262 reported "PASSED: -8 / FAILED: +12" although the branch changes nothing for the testsuite.
This refactors the codebase to have a more similar structure to uutils/coreutils. Each of the utils have been moved into their own crates under `src/uu` and shared code has been moved into the `src/uucore` crate. Each util crate has a symlink to the licences in the root of the repo.
The name `uucore` belongs to the shared crate of uutils/coreutils, so the shared code of diffutils cannot use it. Rename the crate (and its directory) to `diffutils_core`. Also: - drop the stray `src/uu/cmp/Cargo.lock` (workspace members share the root lockfile) - add the LICENSE symlinks to the shared crate, like the util crates - add `description`/`repository` metadata to the new crates - move the root crate's test-only dependencies back to dev-dependencies Claude-Session: https://claude.ai/code/session_01QK4eB5VFJ91FmZYFy3kphk
sylvestre
force-pushed
the
split-into-separate-crates
branch
from
August 24, 2026 20:56
17daa24 to
bc9defb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the codebase to have a more similar structure to uutils/coreutils.
Each of the utils have been moved into their own crates under
src/uuand shared code has been moved into thesrc/uucorecrate. Each util crate has a symlink to the licences in the root of the repo.The changes here are purely a refactor - nothing else has been changed.