chore: bump @nativescript-community/perms devDependency to v3 - #679
Open
NathanWalker wants to merge 1 commit into
Open
chore: bump @nativescript-community/perms devDependency to v3#679NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
Type resolution for the workspace builds. The perms v3 typings differ enough from v2 that packages cannot compile against the wrong major: `Result` became generic and `LocationOptions.type` was replaced by `background`. Merge after the camera, contacts, geolocation and imagepicker migrations — those packages do not compile against v3 until then. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace's perms devDependency drives type resolution for every package build. The v3 typings differ enough from v2 that a package cannot compile against the wrong major:
Resultbecame generic (Result<T>); referencing it bare isTS2315/TS2314LocationOptions.typewas replaced bybackgroundMerge last
This one line is what breaks — or fixes — the workspace build depending on ordering:
camera/geolocation/imagepickerstop compiling.Merging all five together is the only state where
mainbuilds. There is no PR CI in this repo, so nothing will flag the intermediate state.The set
All five packages (plus
local-notifications, already on v3) build clean with the whole set applied, verified against the installed perms 3.0.11.package-lock.jsonis gitignored here, so there is no lockfile change.🤖 Generated with Claude Code