Skip to content

chore: bump @nativescript-community/perms devDependency to v3 - #679

Open
NathanWalker wants to merge 1 commit into
mainfrom
chore/perms-v3-devdependency
Open

chore: bump @nativescript-community/perms devDependency to v3#679
NathanWalker wants to merge 1 commit into
mainfrom
chore/perms-v3-devdependency

Conversation

@NathanWalker

@NathanWalker NathanWalker commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

The workspace's perms devDependency drives type resolution for every package build. The v3 typings differ enough from v2 that a package cannot compile against the wrong major:

  • Result became generic (Result<T>); referencing it bare is TS2315/TS2314
  • LocationOptions.type was replaced by background

Merge last

This one line is what breaks — or fixes — the workspace build depending on ordering:

  • With this merged and the migrations not, camera / geolocation / imagepicker stop compiling.
  • With the migrations merged and this not, those same packages stop compiling.

Merging all five together is the only state where main builds. There is no PR CI in this repo, so nothing will flag the intermediate state.

The set

All five packages (plus local-notifications, already on v3) build clean with the whole set applied, verified against the installed perms 3.0.11.

package-lock.json is gitignored here, so there is no lockfile change.

🤖 Generated with Claude Code

Type resolution for the workspace builds. The perms v3 typings differ
enough from v2 that packages cannot compile against the wrong major:
`Result` became generic and `LocationOptions.type` was replaced by
`background`.

Merge after the camera, contacts, geolocation and imagepicker
migrations — those packages do not compile against v3 until then.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61e98cb7-9ee5-46df-a407-4be489e673d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant