ext/readline: declare true as the return type of readline_completion_function() - #23433
Open
lacatoire wants to merge 1 commit into
Open
ext/readline: declare true as the return type of readline_completion_function()#23433lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
LamentXU123
approved these changes
Aug 24, 2026
Member
|
I don't think this needs a test tho. |
…function() The returned value was RETURN_BOOL(rl_attempted_completion_function != NULL) on the line right after that variable is assigned the address of a static function, so it is true unconditionally. Return true directly and declare it.
lacatoire
force-pushed
the
fix/readline-completion-function-true
branch
from
August 24, 2026 08:06
3786224 to
aafd86d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readline_completion_function()is declaredbool, but the function assigns a static function pointer torl_attempted_completion_functionand then returnsRETURN_BOOL(rl_attempted_completion_function != NULL)— a tautology. The only other exit is theTypeErrorfrom ZPP.trueis always returned.The commit declares
trueand returns it directly instead of the redundant pointer comparison.ksort(),asort(), andnatsort()already declaretruein ext/standard, so this follows existing practice.Changes:
readline.stub.php(bool→true),readline.c(RETURN_BOOL(...)→RETURN_TRUE), regenerated arginfo, added test.