Skip to content

feat(orch): Consume hook events - #608

Merged
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/hook-wiring
Aug 24, 2026
Merged

feat(orch): Consume hook events#608
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/hook-wiring

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Register the orchestrator's hook stage, so lifecycle events are consumed from the queue and handed to the integrations each event resolves to. No integration is wired yet, so events are accepted and discarded.
  • Register the matching dead-letter stage, so an event that fails every retry is recorded and alerted on instead of accumulating unread.

Why:

  • Prove the delivery path end to end before anything produces an event, so a later change adds producers to a route that already works.
  • Keep a deployment with no integrations configured distinguishable from one that is silently losing events.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. Since nothing publishes hook events yet and the resolver returns only a no-op hook, no side effect is lost.

Issues

Stack

  1. feat(hook): Deliver events to integrations #607
  2. @ feat(orch): Consume hook events #608
  3. feat(stovepipe): Consume hook events #632

@prathshenoy
prathshenoy marked this pull request as ready for review August 18, 2026 00:30
@prathshenoy prathshenoy changed the title feat(orchestrator): Consume hook events feat(orch): Consume hook events Aug 18, 2026

@mnoah1 mnoah1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up - you can wire this into stovepipe both here, and within our internal service.

behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Aug 19, 2026
## Summary
**What**:
- Define the shared event format every domain publishes for
fire-and-forget lifecycle notifications, carrying origin, type, timing,
a staleness marker, and open per-event detail.
- Derive an event's identity from the transition it describes, so
replaying a transition produces the same identity and duplicate
deliveries collapse.

**Why**:
- Enable integrations to react to pipeline milestones without adding
call sites that can stall or fail a merge.
- Establish one schema and one identity rule before any producer ships,
so a consumer spanning several domains needs only one reader.

## Test Plan
- [x] Add unit tests.

## Revert Plan
- Revert this PR. No topic is registered and no message of this shape
exists on any queue.

## Issues
-
[CODEM-416](https://linear.app/uber/issue/CODEM-416/hooks-integration-downstream-notificaiton)

## Stack
1. @ uber#606
1. uber#607
1. uber#608
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch 4 times, most recently from 8503587 to 07e57cc Compare August 24, 2026 17:20
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-wiring branch from 480e8cc to 4826405 Compare August 24, 2026 17:51
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch 2 times, most recently from e297c9d to e08c06b Compare August 24, 2026 19:35
@behinddwalls

Copy link
Copy Markdown
Collaborator

⚠️ Automatic stack rebase failed

This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution.

To fix manually:

git fetch origin
git checkout prath.shenoy/hook-wiring
git rebase --onto origin/main e08c06bf4aad707f895d58dffb99131c423ea644 prath.shenoy/hook-wiring
# resolve conflicts, then:
git push --force-with-lease

Then update this PR's base branch:

gh pr edit 608 --base main

@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-wiring branch from e7ab41a to a8d95e4 Compare August 24, 2026 19:50
@prathshenoy
prathshenoy changed the base branch from prath.shenoy/hook-dispatch to main August 24, 2026 19:51
@prathshenoy
prathshenoy added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit ac94e24 Aug 24, 2026
15 checks passed
@prathshenoy
prathshenoy deployed to stack-rebase August 24, 2026 20:00 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the prath.shenoy/hook-wiring branch August 24, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants