Skip to content

feat(stovepipe): Consume hook events - #632

Merged
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/hook-stovepipe
Aug 24, 2026
Merged

feat(stovepipe): Consume hook events#632
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/hook-stovepipe

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Register the hook stage and its dead-letter stage in Stovepipe's consumer wiring, on a topic named for the domain, with a resolver that hands every event to the no-op hook.

Why:

  • Wire the stage in a second domain, so attaching a real integration to Stovepipe is a resolver swap rather than new plumbing, and two domains on one queue backend keep their own hook topics.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. Nothing publishes hook events yet and the resolver returns only a no-op hook.

Issues

Stack

  1. feat(hook): Deliver events to integrations #607
  2. feat(orch): Consume hook events #608
  3. @ feat(stovepipe): Consume hook events #632

@prathshenoy
prathshenoy changed the base branch from main to prath.shenoy/hook-wiring August 24, 2026 18:28
This was referenced Aug 24, 2026
Merged
Merged
@prathshenoy
prathshenoy marked this pull request as ready for review August 24, 2026 18:33
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-wiring branch from e7ab41a to a8d95e4 Compare August 24, 2026 19:50
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-stovepipe branch from d13d204 to e25509e Compare August 24, 2026 19:52
@prathshenoy @github-actions
feat(stovepipe): Consume hook events
69133dd 
**What**:
- Consume lifecycle events on Stovepipe's own hook topic and hand each one to the integrations it resolves to, accepting and discarding them while only the no-op integration is attached.
- Record and alert on an event that fails every retry, rather than letting it accumulate unread.

**Why**:
- Show the delivery stage works for a second domain, one that registers its consumers directly rather than through the pipeline topology.
- Keep two domains sharing a queue backend from consuming each other's events.
@behinddwalls
behinddwalls force-pushed the prath.shenoy/hook-stovepipe branch from e25509e to 69133dd Compare August 24, 2026 20:00
@behinddwalls
behinddwalls changed the base branch from prath.shenoy/hook-wiring to main August 24, 2026 20:00
@prathshenoy
prathshenoy enabled auto-merge August 24, 2026 20:01
@prathshenoy
prathshenoy added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit c93310d Aug 24, 2026
15 of 27 checks passed
@prathshenoy
prathshenoy deployed to stack-rebase August 24, 2026 20:11 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the prath.shenoy/hook-stovepipe branch August 24, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnoah1 mnoah1 mnoah1 approved these changes
@behinddwalls behinddwalls Awaiting requested review from behinddwalls behinddwalls is a code owner
@sbalabanov sbalabanov Awaiting requested review from sbalabanov sbalabanov is a code owner

Assignees

No one assigned

Labels

AutoMerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prathshenoy @mnoah1